Add runtime.TupleMirror to avoid anonymous classes for mirrors of tuples #15404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com> Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>
bishabosha
added
the
needs-minor-release
bishabosha
force-pushed
the
add-runtime-tuplemirror
branch
from
136dcc4 to
a2c15a3
Compare
bishabosha
force-pushed
the
add-runtime-tuplemirror
branch
from
a2c15a3 to
368673d
Compare
nicolasstucki
approved these changes
Jun 9, 2022
|
What do you think about adding a runtime constructor for anonymous mirrors that takes a function? Then we could reduce the amount of generated code to a single lambda which doesn't need an anonymous class. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the
runtime.TupleMirrorclass as a way to decrease bytecode generation for mirrors of Tuples. Also adapts mirror synthesis to use TupleMirror for mirrors of tuples.Follow up work is to enable Synthesizer to accept tuples of arity > 22
fixes #15399