Resolve overloading: keep track of prefix and indices of all default getters #16009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getters When resolving overloading using parameter lists after the first one, we used mapped symbols that forgot about the prefix of the original call and how many parameters were skipped. Consequently, overloading resolution got confused when there were default parameters in following parameter lists. We now keep track of these values in an annotation that gets added to the mapped symbols. We also use `findDefaultGetter` directly to compute the number of default parameters in `sizeFits`. The previous scheme of checking the `HasParam` flag of parameters fails for default values inherited from overriden methods.
odersky
changed the title
Default arguments in later parameter sections are functions that take ealier arguments as parameters. When we just want to test whether a method is applicable, we don't keep track of these earlier arguments. Therefore, we always assume in this case that a default getter matches, if one was found.
We need to show argument lists after the first one if they were used for overloading resolution.
|
This PR fixes two bugs but has been lingering for 4 weeks with no review. Going to merge. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16006
Fixes #15287
When resolving overloading using parameter lists after the first one, we used mapped
symbols that forgot about the prefix of the original call and how many parameters were
skipped. Consequently, overloading resolution got confused when there were default
parameters in following parameter lists. We now keep track of these values in an
annotation that gets added to the mapped symbols.
We also use
findDefaultGetterdirectly to compute the number of default parametersin
sizeFits. The previous scheme of checking theHasParamflag of parametersfails for default values inherited from overriden methods.