Expose reason for unchecked local class warning #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
unchecked-bc
branch
from
1dba232 to
e980e8f
Compare
dwijnand
force-pushed
the
unchecked-bc
branch
from
e980e8f to
417c9f5
Compare
|
The tabloid headline: "Unchecked Warning: Exposed!" |
odersky
requested changes
Oct 10, 2022
| * 1. if `X <:< P`, TRUE | ||
| * 2. if `P` is a singleton type, TRUE | ||
| * 3. if `P` refers to an abstract type member or type parameter, FALSE | ||
| * 1. if `X <:< P`, "" |
There was a problem hiding this comment.
I'd prefix this with a comment that the method returns a string explaining why the type is not checkable, or the empty string if it is checkable.
| if (!isTrusted && !checkable(expr.tpe, argType, tree.span)) | ||
| report.uncheckedWarning(i"the type test for $argType cannot be checked at runtime", expr.srcPos) | ||
| transformTypeTest(expr, tree.args.head.tpe, | ||
| val unchecked = expr.tpe.widenTermRefExpr.hasAnnotation(defn.UncheckedAnnot) |
There was a problem hiding this comment.
No need to encode isTrusted as empty strings.
I think renaming checkable to whyUncheckable and changing the logic as below would make things clearer.
val isUnchecked = expr.tpe.widenTermRefExpr.hasAnnotation(defn.UncheckedAnnot)
if !isTrusted && !isUnchecked then
val whyNot = whyUncheckable(expr.tpe, argType, tree.span)
if !whyNot.isEmpty then
report.uncheckedWarning
dwijnand
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.