community: Add configurable text key for indexing and the retriever in Pinecone Hybrid Search #29697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
ccurme
approved these changes
Feb 10, 2025
dosubot
bot
added
the
lgtm
bluearrow98
pushed a commit
to bluearrow98/langchain
that referenced
this pull request
Feb 13, 2025
…n Pinecone Hybrid Search (langchain-ai#29697) **issue** In Langchain, the original content is generally stored under the `text` key. However, the `PineconeHybridSearchRetriever` searches the `context` field in the metadata and cannot change this key. To address this, I have modified the code to allow changing the key to something other than context. In my opinion, following Langchain's conventions, the `text` key seems more appropriate than `context`. However, since I wasn't sure about the author's intent, I have left the default value as `context`.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
In Langchain, the original content is generally stored under the
textkey. However, thePineconeHybridSearchRetrieversearches thecontextfield in the metadata and cannot change this key. To address this, I have modified the code to allow changing the key to something other than context.In my opinion, following Langchain's conventions, the
textkey seems more appropriate thancontext. However, since I wasn't sure about the author's intent, I have left the default value ascontext.