Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Vearch client is incompatible #77

Open
Dreamerily opened this issue Feb 6, 2025 · 3 comments
Open

[BUG] Vearch client is incompatible #77

Dreamerily opened this issue Feb 6, 2025 · 3 comments
Labels
bug Something isn't working P2 High priority theme: embedding store Issues/PRs related to embedding store

Comments

@Dreamerily
Copy link

Dreamerily commented Feb 6, 2025

The properties of ListSpaceResponse do not match the 3.5.x version. The current property is name and should be space_name.

Image

Image

LangChain4j Community version: 1.0.0-alpha1

https://vearch.readthedocs.io/en/v3.5.x/use_op/op_space.html#view-space

@Dreamerily Dreamerily added the bug Something isn't working label Feb 6, 2025
@Martin7-1
Copy link
Collaborator

Martin7-1 commented Feb 6, 2025

@Dreamerily Thank you! But it works fine in vearch 3.5.x versions. Looks like the api is compatible. Do you encounter any excception?

@Dreamerily
Copy link
Author

@Dreamerily Thank you! But it works fine in vearch 3.5.x versions. Looks like the api is compatible. Do you encounter any excception?

VearchEmbeddingStore.builder().build() checks the existence of a space by calling isSpaceExist method, which compares the space_name with the name field in ListSpaceResponse. However, the name field in ListSpaceResponse is always null, resulting in isSpaceExist always returning false. As a consequence, the program proceeds to execute VearchEmbeddingStore.createSpace(), which then raises an error indicating that the space already exists.

Except for the aforementioned situations, I haven’t encountered any other issues.

@Martin7-1
Copy link
Collaborator

@Dreamerily Thank you! But it works fine in vearch 3.5.x versions. Looks like the api is compatible. Do you encounter any excception?

VearchEmbeddingStore.builder().build() checks the existence of a space by calling isSpaceExist method, which compares the space_name with the name field in ListSpaceResponse. However, the name field in ListSpaceResponse is always null, resulting in isSpaceExist always returning false. As a consequence, the program proceeds to execute VearchEmbeddingStore.createSpace(), which then raises an error indicating that the space already exists.

Except for the aforementioned situations, I haven’t encountered any other issues.

@Dreamerily Thank you for your detailed explanation! Would you like to contribute it?

@Martin7-1 Martin7-1 added P2 High priority theme: embedding store Issues/PRs related to embedding store labels Feb 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working P2 High priority theme: embedding store Issues/PRs related to embedding store
Projects
None yet
Development

No branches or pull requests

2 participants