Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong message when no custom tool available in custom tool list. #10584

Closed
5 tasks done
weimzh opened this issue Nov 12, 2024 · 1 comment · Fixed by #11851
Closed
5 tasks done

Wrong message when no custom tool available in custom tool list. #10584

weimzh opened this issue Nov 12, 2024 · 1 comment · Fixed by #11851
Assignees

Comments

@weimzh
Copy link
Contributor

weimzh commented Nov 12, 2024

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

0.11.1

Cloud or Self Hosted

Cloud

Steps to reproduce

  1. open https://cloud.dify.ai/tools?category=api
  2. make sure list of custom tools is empty.

✔️ Expected Behavior

show "no custom tool available, click 'Create custom tool' to add one" or something similar.

❌ Actual Behavior

Shows: "No workflow tool available, Go to "Workflow -> Publish as Tool"", which is misleading.

Copy link

dosubot bot commented Nov 12, 2024

Hey @weimzh! 👋 I'm here to help you with bugs, questions, or becoming a contributor. I'll assist you while we wait for a human maintainer.

The issue you're encountering is due to the incorrect message being displayed when no custom tools are available. The message currently shown is intended for workflow tools, not custom tools. To resolve this, the message logic needs to be updated to differentiate between the absence of custom tools and workflow tools.

The message for "No workflow tool available" is defined in the addToolModal section of the codebase, specifically in the translation files like web/i18n/en-US/tools.ts [1]. To fix the issue, you would need to modify the logic that determines which message to display based on the context (i.e., whether the list pertains to custom tools or workflow tools) and update the translation files accordingly to reflect the correct message for each scenario.

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 13, 2024
@crazywoola crazywoola self-assigned this Dec 19, 2024
@crazywoola crazywoola removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants