From ded218c45265728d46353891a2f7397a5cb6a793 Mon Sep 17 00:00:00 2001
From: Mior Muhammad Zaki <crynobone@gmail.com>
Date: Wed, 13 Nov 2024 18:58:40 +0800
Subject: [PATCH] [2.x] Supports PHP 8.4

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
---
 .github/workflows/tests.yml | 9 +++++----
 src/Subscription.php        | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 3038c40..0361116 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -16,11 +16,13 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.1, 8.2, 8.3]
+        php: [8.1, 8.2, 8.3, 8.4]
         laravel: [10, 11]
         exclude:
           - php: 8.1
             laravel: 11
+          - php: 8.4
+            laravel: 10
 
     name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }}
 
@@ -39,11 +41,10 @@ jobs:
 
       - name: Install dependencies
         run: |
-           composer require "illuminate/contracts=^${{ matrix.laravel }}" --no-update
-           composer update --prefer-dist --no-interaction --no-progress
+           composer update --prefer-dist --no-interaction --no-progress --with=""illuminate/contracts=^${{ matrix.laravel }}""
 
       - name: Execute tests
-        run: vendor/bin/phpunit
+        run: vendor/bin/phpunit --display-deprecations --fail-on-deprecation
         env:
           PADDLE_SELLER_ID: ${{ secrets.PADDLE_SELLER_ID }}
           PADDLE_API_KEY: ${{ secrets.PADDLE_API_KEY }}
diff --git a/src/Subscription.php b/src/Subscription.php
index 8237559..48272ec 100644
--- a/src/Subscription.php
+++ b/src/Subscription.php
@@ -911,7 +911,7 @@ public function nextPayment()
      * @param  string|null  $include
      * @return array
      */
-    public function asPaddleSubscription(string $include = null)
+    public function asPaddleSubscription(?string $include = null)
     {
         $include = $include ? ['include' => $include] : [];