Prevent overwriting Link headers in AddLinkHeadersForPreloadedAssets …

…middleware (#53463)
laravel · Nov 11, 2024 · 378bd56 · 378bd56
1 parent f405bf0
commit 378bd56
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/src/Illuminate/Http/Middleware/AddLinkHeadersForPreloadedAssets.php b/src/Illuminate/Http/Middleware/AddLinkHeadersForPreloadedAssets.php
@@ -21,7 +21,7 @@ public function handle($request, $next)
             if ($response instanceof Response && Vite::preloadedAssets() !== []) {
                 $response->header('Link', Collection::make(Vite::preloadedAssets())
                     ->map(fn ($attributes, $url) => "<{$url}>; ".implode('; ', $attributes))
-                    ->join(', '));
+                    ->join(', '), false);
             }
         });
     }

diff --git a/tests/Http/Middleware/VitePreloadingTest.php b/tests/Http/Middleware/VitePreloadingTest.php
@@ -54,8 +54,8 @@ public function testItAddsPreloadLinkHeader()
         });
 
         $this->assertSame(
+            '<https://laravel.com/app.js>; rel="modulepreload"; foo="bar"',
             $response->headers->get('Link'),
-            '<https://laravel.com/app.js>; rel="modulepreload"; foo="bar"'
         );
     }
 
@@ -79,4 +79,31 @@ public function testItDoesNotAttachHeadersToNonIlluminateResponses()
 
         $this->assertNull($response->headers->get('Link'));
     }
+
+    public function testItDoesNotOverwriteOtherLinkHeaders()
+    {
+        $app = new Container;
+        $app->instance(Vite::class, new class extends Vite
+        {
+            protected $preloadedAssets = [
+                'https://laravel.com/app.js' => [
+                    'rel="modulepreload"',
+                    'foo="bar"',
+                ],
+            ];
+        });
+        Facade::setFacadeApplication($app);
+
+        $response = (new AddLinkHeadersForPreloadedAssets)->handle(new Request, function () {
+            return new Response('Hello Laravel', headers: ['Link' => '<https://laravel.com/logo.png>; rel="preload"; as="image"']);
+        });
+
+        $this->assertSame(
+            [
+                '<https://laravel.com/logo.png>; rel="preload"; as="image"',
+                '<https://laravel.com/app.js>; rel="modulepreload"; foo="bar"',
+            ],
+            $response->headers->all('Link'),
+        );
+    }
 }