-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WSL Rework Discussion #1957
Comments
Hi @svpernova09, Regarding PostgreSQL, I am of the opinion that it shouldn't be part of wsl install as in amd64.sh of laravel/settler it installs and then disable the service |
Agree about PostgreSQL being a feature
What is this for if i may ask? |
@svpernova09 Correct me if I'm wrong but I think we also need an apache feature script, Nginx gets installed in wsl-init but if there's gonna be an site with type "apache" or "apache-proxy", the apache type or apache-proxy will be used but there's no webserver homestead/scripts/site-types/apache.sh Line 26 in 219e126
This line will fail in both site type scripts for WSL |
Right, PostgreSQL has been moved to a feature and remove from
I've been burned in the past with running bash scripts within bash scripts and want to do a quick test to ensure variables persist as expected.
I don't think we need a feature. We could install and disable it which is what settler does today. |
@svpernova09 , I created a new PR with my changes #1958. Please merge this instead of #1956 I closed this PR. Thanks. |
Hi, Just catching up, hope you guys are doing well, what are our next steps with this, let me know if I can help with something to take this further, got some free time next week. Thanks |
Would it be an idea to revert #1933 so that we can have mailpit on WSL? |
Hey guys, Got a solid test out of the wsl-rework branch on Ubuntu 20.04, 22.04 and deploying works perfectly. Few extra notes:
homestead/src/WslCreateDatabaseCommand.php Lines 68 to 77 in 36bd28d
Would be a good idea i think. |
Hello, I understood why I couldn't establish a connection to the database: the port to use is 3306 and not 33060. Something that wasn't clear to me when I first tried WSL2 with Homestead is that certain parameters of Homestead.yaml are not taken into account. For example : ip, cpus, memory, ports, ... Here is the list of parameters not taken into account in my case: Also, the IP to use for mapping homestead.test domain in I can suggest a PR to improve the documentation if you think it is a good idea ? In fact, it would make sense to have specific parameters for WSL only : |
@svpernova09 guys, I would like to help. can someone guide on where to start from here? @sdespont I've read your comment, and I do agree that's a better option for flexibility and support for both WSL and VM. |
To maintain fast and efficient synchronization with WSL of source files managed under Windows with an IDE , it could be very interesting to try Mutagen https://mutagen.io Perfs should be better than NFS and should be easy to setup |
Goal
Continuing work in #1949 by @MichaelBelgium and integrating #1956 from @karmendra
Complete
Complete is a fully functional Homestead-like Ubuntu 22.04 system with associated documentation.
Branch and Status
Work is being done on the
wsl-rework
branch. I've tested a freshbento/ubuntu-22.04
Vagrant box and runsudo ./bin/wsl-init
installed the base system as expected.wsl-init
, should probably be a feature. Thoughts?scripts/features/php8.3.sh
The text was updated successfully, but these errors were encountered: