Skip to content

Version 1.21 introduced a breaking change #356

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
WendellAdriel opened this issue Mar 3, 2025 · 3 comments
Closed

Version 1.21 introduced a breaking change #356

WendellAdriel opened this issue Mar 3, 2025 · 3 comments

Comments

@WendellAdriel
Copy link

Pint Version

1.21.0

PHP Version

8.1

Description

Since my other issue #355 was closed without any discussions, I'm creating a new one.

As already stated in the previous issue, version 1.21 added a breaking change with this PR: #330 by bumping the minimum version of PHP from 8.1 to 8.2.

Adding more context to this. Any applications using Laravel Pint version 1 that are still running in PHP 8.1 and having it in the CI/CD pipeline would have the CI/CD pipelines broken because of this change.

This would make sense by having version 1.21 released as version 2.0 instead to not add a breaking change as mentioned above for any applications.

Steps To Reproduce

One example of CI/CD pipeline with GitHub Actions failing: https://github.com/WendellAdriel/laravel-validated-dto/actions/runs/13545515191/job/37856055896

Here I had actions that stopped working because of Pint v1.21 changing the minimum supported version for PHP from 8.1 to 8.2

@crynobone
Copy link
Member

  • v1.6.0 upgrade from PHP 8.0 to 8.1.
  • Bumping minimum dependencies isn't a breaking change.
  • The changes was made to support newer PHP version

@WendellAdriel
Copy link
Author

@crynobone again closing without any discussions?
Man, I'm not saying to not release something, but this is a breaking change.
I just showed you one example that broke a project and that's only one example.

I feel like closing these issues without any discussions is a disrespect to the person who created the issue.

@crynobone
Copy link
Member

You can use older laravel/pint version to cover older php version.

-"laravel/pint": "^1.21",
+"laravel/pint": "^1.20",

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants