Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update 'notify_team_new_comment' GitHub action to ignore comments by the Sentry bot #12568

Open
MisRob opened this issue Aug 16, 2024 · 8 comments
Assignees
Labels
community-contribution-in-progress github_actions Pull requests that update GitHub Actions code help wanted Open source contributors welcome TAG: dev experience Build performance, linting, debugging...

Comments

@MisRob
Copy link
Member

MisRob commented Aug 16, 2024

Summary

Update 'notify_team_new_comment' GitHub action to ignore comments by the Sentry bot

Observed behavior

The GitHub action that sends a Slack notification when a contributor comments on issue, .github/workflows/notify_team_new_comment.yml, sends us notifications for comments by the Sentry bot sentry-io[bot]:

Screenshot from 2024-08-16 19-54-33

Related comment: learningequality/studio#4643 (comment)

Expected behavior

notify_team_new_comment is updated so that we don't receive notifications from sentry-io[bot].

Comments

Unless #12567 is resolved at first, note that copies of this action need to be updated in the same way in the following repositories:

  • Studio
  • Kolibri Design System
    • Even though strictly speaking we're not receiving comments from Sentry there, it'll be good to keep them consistent because of the plan to make it into a re-usable action
@MisRob MisRob added TAG: dev experience Build performance, linting, debugging... github_actions Pull requests that update GitHub Actions code labels Aug 16, 2024
@josephinoo
Copy link

Hi @MisRob MisRob! 👋 Is this issue open for contributions?

@MisRob
Copy link
Member Author

MisRob commented Jan 21, 2025

Hi @josephinoo, I'm happy to assign this to you. I'm not exactly sure how to identify that the author is Sentry bot. Would you be able to research it and test it?

@josephinoo
Copy link

Thanks, @MisRob , I'll look into it and if I find anything I'll let you know.

@MisRob
Copy link
Member Author

MisRob commented Jan 31, 2025

Hi @josephinoo, I've just realized we will also need to ignore comments by Learning Equality bot such as this one

Image

would you like to include it in this issue, or should I open a new one?

Meanwhile I realized there should be a simple way to figure out what's the bot's name, since we actually show it exactly as it is in the Slack message. Code for it is github.event.comment.user.login (reference) so I think just comparing that to "sentry-io[bot]" and "learning-equality-bot[bot]" in a condition should do.

@Sanchit-100
Copy link

Hi @MisRob .
Hi @josephinoo . I would like to know if you are working on this issue.
If you are busy otherwise, I would like to get this assigned.
Thanks

@MisRob
Copy link
Member Author

MisRob commented Feb 12, 2025

Hi @Sanchit-100, since we didn't hear back from @josephinoo here and on other issues for several weeks, I will re-assign. Please see the comments above with the additional guidance.

@MisRob
Copy link
Member Author

MisRob commented Feb 12, 2025

Thank you

@MisRob MisRob assigned Sanchit-100 and unassigned josephinoo Feb 12, 2025
@MisRob MisRob added help wanted Open source contributors welcome community-contribution-in-progress labels Feb 12, 2025
@iamshobhraj
Copy link
Contributor

iamshobhraj commented Feb 23, 2025

Hi @Sanchit-100 , are you working on this issue?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community-contribution-in-progress github_actions Pull requests that update GitHub Actions code help wanted Open source contributors welcome TAG: dev experience Build performance, linting, debugging...
Projects
None yet
Development

No branches or pull requests

4 participants