-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Migrate this Ruby/Sinatra app to an HTML/JS app 🎃 #17
Comments
I'd love to give this a go! Shall I fork & PR or would you rather keep the two implementations separate? |
Awesome - thanks @jack-lewin! Please feel free to fork this this repo and create a PR 🤘🎃 |
@leereilly still need to write tests before I create a PR, but here's my effort in the meantime. Let me know if there are any problems! ✌️ |
This is awesome, @jack-lewin - nice to see the avatars show up again also! Can't wait to merge with with master 🤘 I wonder if there's an opportunity to move away from Heroku to do all of it client-side and host it on GitHub Pages? E.g. something like https://github.com/andrew/first-pr? |
@leereilly sure thing! I'm pretty busy over the next few days, but will take a look as soon as I get the chance 🙂 |
Hi @leereilly! Just been looking at getting this to work on GitHub Pages. My understanding is that it's possible to achieve, but not without breaking old links - see this article for reference. A possible solution would be to structure URLs as What do you reckon? 🎃 |
Hi @jack-lewin - thanks for looking into it! For this particular app, I don't think we need to be concerned about breaking (uniquer) links aren't indexed / hardcoded in too many places. Your approach good to me! |
I built this little web app 6 years ago to experiment with Heroku, Sinatra and the GitHub API. I think it'd be cool to see it reimplemented as a simple HTML + JS app hosted on GitHub Pages. If any Hactoberfesters would be interested in tackling this, I'd welcome your help 🎃
How to use it
Visit http://gitscore.herokuapp.com, and enter in any public GitHub repository into the textfield. You'll see a high score table similar to the following:
How it works
The app basically takes the repository that the user enters and hits the GitHub API for a list of contributors (see the Repository › List Contributors endpoint). E.g. For the leereilly/games repository, it'd make a call to the following:
https://api.github.com/repos/leereilly/games/contributors
TRY ITWhich would return a JSON object like this:
Then it just takes that first list of users (already ordered by number of contributions), and throws 'em in a table. To calculate the high score, it just multiplies the
contributions
value by 10.Once we have an MVP, I may have some additional feature requests. Comments and questions most welcome! 😉
Cheers,
Lee 🍻
The text was updated successfully, but these errors were encountered: