Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Doesn't work with modern emacs #1

Open
icarus-sparry opened this issue Aug 26, 2021 · 2 comments · May be fixed by #3
Open

Doesn't work with modern emacs #1

icarus-sparry opened this issue Aug 26, 2021 · 2 comments · May be fixed by #3

Comments

@icarus-sparry
Copy link

In April 2020 arc-mode.el changed from using vectors of strings to vectors of structs to represent files inside archives. That change breaks this code which generates strings.

Reproduction:
` load this code into recent emacs
load an rpm file.
Observe type error when archive-summarize-files tries to extract the archive--file-summary-name-start field from a string.

At the moment I am not sure what a good fix would be.
Clearly the code can be updated to generate the structs rather than the strings, but I don't currently know how to figure out how to choose the string or the struct.
nbarrientos referenced this issue in nbarrientos/archive-rpm Feb 19, 2022
@nbarrientos
Encapsulate files into objects of type archive--file-summary
3dcf306 
Fixes #1
@nbarrientos nbarrientos linked a pull request Feb 19, 2022 that will close this issue
Open
nbarrientos referenced this issue in nbarrientos/archive-rpm Feb 19, 2022
@nbarrientos
Encapsulate file summaries and descriptions into structs
a5f5645 
Now the package uses the structs defined in arc-mode.el:
archive--file-desc and archive--file-summary.

Fixes #1
@nbarrientos
Copy link

This bug has now a proposed fix.

nbarrientos referenced this issue in nbarrientos/archive-rpm Feb 20, 2022
@nbarrientos
Encapsulate file summaries and descriptions into structs
80ba026 
Now the package uses the structs defined in arc-mode.el:
archive--file-desc and archive--file-summary. Emacs 28 and beyond
only.

Fixes #1
nbarrientos referenced this issue in nbarrientos/archive-rpm Mar 14, 2022
@nbarrientos
Encapsulate file summaries and descriptions into structs
0ec72bb 
Now the package uses the structs defined in arc-mode.el:
archive--file-desc and archive--file-summary. Emacs 28 and beyond
only.

Fixes #1
@nbarrientos
Copy link

This issue has been addressed in the repository MELPA points to now, more info: melpa/melpa#7945

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encapsulate file summaries and descriptions into structs nbarrientos/archive-rpm
2 participants
@nbarrientos @icarus-sparry