Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Logging of hidden qualities prefers id over qualityId #3

Closed
kkotenko opened this issue May 3, 2022 · 2 comments
Closed

Logging of hidden qualities prefers id over qualityId #3

kkotenko opened this issue May 3, 2022 · 2 comments

Comments

@kkotenko
Copy link
Contributor

kkotenko commented May 3, 2022

Setup
Here is a partial response to a request to /storylet (particularly "Approaching the Lifeberg's Hunting Grounds"):

{
	"qualityRequirements": [
		{
			"allowedOn": "Character",
			"qualityId": 142286,
			"qualityName": "Zailing Route",
			"tooltip": "You unlocked this with <span class='quality-name'>Zailing Route</span> 3<em> (you needed exactly 3)</em>",
			"category": "Hidden",
			"nature": "Status",
			"status": "Unlocked",
			"isCost": false,
			"image": "evade2",
			"id": 201395
		},

	]
}

Observed behavior:
The extension logged the value of id to the console:

[FL Quality Lantern] Hidden quality: Zailing Route (ID: 201395)

Expected behavior:
The extension logs the value of qualityId to the console.
[FL Quality Lantern] Hidden quality: Zailing Route (ID: 142286)

Additional information:
From what I understand, id 201395 is the ID of the primary key of the database entry which connects the storylet "Approaching the Lifeberg's Hunting Grounds" to the quality Zailing Route. "Zailing Route" has ID 142286.

I am not sure when FL chooses to serve a JSON which contains the id of the property in "id" or "qualityId". I believe that if qualityId is present, it is always to be preferred over id.

@lensvol
Copy link
Owner

lensvol commented May 4, 2022

Thanks, will fix it.

@lensvol
Copy link
Owner

lensvol commented May 4, 2022

Fixed in 17b8b52

@lensvol lensvol closed this as completed May 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants