Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add basic https support to memgpt server for development where https is needed #1052

Merged
merged 6 commits into from
Feb 25, 2024

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Feb 23, 2024

Closes #1043

  • Adds ability to start memgpt server in HTTPS mode
    • memgpt server --use-ssl
    • the server will then listen on https instead of http
  • By default, it will create a self-signed cert using OpenSSL
    • NOTE: relies on subprocess, which is probably not great but should do for now
    • Can modify to use a package like cryptography down the line / if the subprocess + openssl combo doesn't work for devs
  • Devs can also use memgpt server --use-ssl --ssl-cert path/to/ssl/certfile --ssl-key path/to/ssl/keyfile to pass a specific cert+key file combo

@cpacker cpacker requested a review from sarahwooders February 25, 2024 15:57
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sarahwooders sarahwooders merged commit 7d61d32 into main Feb 25, 2024
4 checks passed
@sarahwooders sarahwooders deleted the https branch February 25, 2024 22:34
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTPS support natively
2 participants