Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: huggingface embeddings dependency #1087

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: huggingface embeddings dependency #1087

merged 2 commits into from
Mar 5, 2024

Conversation

thefux
Copy link
Contributor

@thefux thefux commented Mar 4, 2024 •
edited
Loading

Please describe the purpose of this pull request.
bug fix

How to test
memgt run

Related issues or PRs
issue

@thefux thefux changed the title #1079 fix huggingface embeddings dependency fix: huggingface embeddings dependency Mar 4, 2024
vampirismtrueblood
vampirismtrueblood reviewed Mar 4, 2024
View reviewed changes
Copy link

@vampirismtrueblood vampirismtrueblood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to raise the same exact PR, but saw this one. Yes this LGTM

sarahwooders
sarahwooders approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- thanks so much for adding this fix!

@cpacker cpacker merged commit 47b5299 into letta-ai:main Mar 5, 2024
3 of 4 checks passed
@sarahwooders sarahwooders mentioned this pull request Mar 6, 2024
Closed
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@thefux @rakez-envisia
@sarahwooders @cpacker
fix: huggingface embeddings dependency (#1087)
81af398 
Co-authored-by: Abderrahmen Rakez <a.rakez@envisia.de>
Co-authored-by: sarahwooders <sarahwooders@gmail.com>
Co-authored-by: cpacker <packercharles@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vampirismtrueblood vampirismtrueblood vampirismtrueblood left review comments

@sarahwooders sarahwooders sarahwooders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thefux @sarahwooders @vampirismtrueblood @cpacker @rakez-envisia