Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: skip empty string passages returned by llama index parsing #1208

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix: skip empty string passages returned by llama index parsing #1208

merged 3 commits into from
Apr 2, 2024

Conversation

sarahwooders
Copy link
Collaborator

For some reason llama-index parsers return nodes with empty strings, which causes errors with computing the embedding.

@sarahwooders sarahwooders requested a review from cpacker April 2, 2024 17:44
cpacker
cpacker approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ggtm

@cpacker cpacker merged commit 4487f28 into main Apr 2, 2024
3 of 4 checks passed
@cpacker cpacker deleted the load-bug branch April 2, 2024 17:49
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@sarahwooders
fix: skip empty string passages returned by llama index parsing (#1208)
114969e
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cpacker cpacker cpacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahwooders @cpacker