Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add workflow to build + test docker container #1278

Merged
merged 38 commits into from
Apr 22, 2024
Merged

feat: add workflow to build + test docker container #1278

merged 38 commits into from
Apr 22, 2024

Conversation

sarahwooders
Copy link
Collaborator

@sarahwooders sarahwooders commented Apr 20, 2024 •
edited
Loading

Please describe the purpose of this pull request.
This PR adds integration tests for the MemGPT server docker container.

  • Run integration tests that build a container with the local code, run the container to create a MemGPT service, and test it with the client-side tests.
  • Remove the need for a client to have a local ~/.memgpt/config if the client is simply connecting to a MemGPT service
  • Allow passing in the server URI with MEMGPT_SERVER_URL to test_client.py

The development container can be built and run with:

docker compose -f dev-compose.yaml up --build -d

Test data is contained in the ./.persist/pgdata-test folder.

How to test
Tests added in .github/workflows/docker-integration-tests.yaml

Have you tested this PR?
Yes

@sarahwooders
upgrade llama-index-embeddings-huggingface package and fix bug with l…
6a2edc6 
…ocal embeddings
@sarahwooders
fix merge
e5d659c
@sarahwooders
test db
83f1415
@sarahwooders
add integration test file
374d240
@sarahwooders
go back to using envs
04f1e40
@sarahwooders
fix config file
9b003dc
@sarahwooders
cleanup client code
dba0f01
@sarahwooders
add port
a9ce4de
@sarahwooders
remove env file requirement
873625f
@sarahwooders
reduce install requirements
45424af
@sarahwooders
add server url
ff72417
@sarahwooders
update server url
0e8cb40
@sarahwooders
set log dir permissions
2fc9ad5
@sarahwooders
remove config
a40288a
@sarahwooders
only run client
089d030
@sarahwooders
Merge branch 'main' into docker-tests
80336e1
@sarahwooders
passing tests locally
e7b7dfb
@sarahwooders
add waiting for service
7d920ef
@sarahwooders
change to bash
a0d3558
@sarahwooders
update poetry lock
c6e8dae
@sarahwooders
remove nginx
61a1d9a
@sarahwooders
move poetry
db8b977
@sarahwooders
print status code
a7e40d6
@sarahwooders
remove error handling
4792298
@sarahwooders
remove try catch
8f5a9d5
@sarahwooders
add docker logs print
8a814a0
@sarahwooders
read openai key from env if not written
0642dbd
@sarahwooders
pass openai key
7564dc6
@sarahwooders
pass in openai key
d170a6e
@sarahwooders
fix typo
2b22ca5
@sarahwooders sarahwooders requested a review from cpacker April 21, 2024 20:37
@sarahwooders sarahwooders merged commit 048e55f into main Apr 22, 2024
5 checks passed
@sarahwooders sarahwooders deleted the docker-tests branch April 22, 2024 00:58
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@sarahwooders
feat: add workflow to build + test docker container (#1278)
7d328fe
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cpacker cpacker cpacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahwooders @cpacker