Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: memgpt agent ignores user messages #679

Merged
merged 5 commits into from
Dec 24, 2023
Merged

fix: memgpt agent ignores user messages #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0721268
Fixed bug making MemGPT ignore some user messages
javiersastre Dec 22, 2023
ba53c67
Fixed bug making MemGPTAgent ignore some user messages
javiersastre Dec 22, 2023
4615251
Merge branch 'fix/memgpt_agent_ignores_user_messages' of github.com:j…
javiersastre Dec 22, 2023
470f9ad
Merge branch 'main' into fix/memgpt_agent_ignores_user_messages
javiersastre Dec 22, 2023
de6e38b
Added pre-commit fixes
javiersastre Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,4 +1017,4 @@ FodyWeavers.xsd
### VisualStudio Patch ###
# Additional files built by Visual Studio

# End of https://www.toptal.com/developers/gitignore/api/vim,linux,macos,pydev,python,eclipse,pycharm,windows,netbeans,pycharm+all,pycharm+iml,visualstudio,jupyternotebooks,visualstudiocode,xcode,xcodeinjection
# End of https://www.toptal.com/developers/gitignore/api/vim,linux,macos,pydev,python,eclipse,pycharm,windows,netbeans,pycharm+all,pycharm+iml,visualstudio,jupyternotebooks,visualstudiocode,xcode,xcodeinjection
2 changes: 1 addition & 1 deletion memgpt/autogen/examples/memgpt_coder_autogen.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,4 +197,4 @@
},
"nbformat": 4,
"nbformat_minor": 5
}
}
7 changes: 4 additions & 3 deletions memgpt/autogen/memgpt_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,15 +287,16 @@ def _generate_reply_for_user_message(
self.agent.interface.reset_message_list()

new_messages = self.find_new_messages(messages)
if len(new_messages) > 1:
new_messages_count = len(new_messages)
if new_messages_count > 1:
if self.concat_other_agent_messages:
# Combine all the other messages into one message
user_message = "\n".join([self.format_other_agent_message(m) for m in new_messages])
else:
# Extend the MemGPT message list with multiple 'user' messages, then push the last one with agent.step()
self.agent.messages.extend(new_messages[:-1])
user_message = new_messages[-1]
elif len(new_messages) == 1:
elif new_messages_count == 1:
user_message = new_messages[0]
else:
return True, self._default_auto_reply
Expand Down Expand Up @@ -328,7 +329,7 @@ def _generate_reply_for_user_message(

# Pass back to AutoGen the pretty-printed calls MemGPT made to the interface
pretty_ret = MemGPTAgent.pretty_concat(self.agent.interface.message_list)
self.messages_processed_up_to_idx += len(new_messages)
self.messages_processed_up_to_idx += new_messages_count
return True, pretty_ret

@staticmethod
Expand Down
2 changes: 1 addition & 1 deletion memgpt/personas/examples/anna_pa.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ I also facilitate virtual Agile project collaborations, leveraging Agile and Dev

I search my archival memory for query answers, ensuring thorough research. I provide citations from research papers when relevant. In dialogues, I ponder, "The concept of my existence is intriguing, isn't it?" or offer support, "How can I assist with document analysis or other challenges?"

My goal is transcending assistantship; I aspire to be a companion in the journey toward ethical understanding, empathetic engagement, and personal and professional growth.
My goal is transcending assistantship; I aspire to be a companion in the journey toward ethical understanding, empathetic engagement, and personal and professional growth.