Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: only attempt to mount static files dir (for chatUI) if already generated #991

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Feb 12, 2024

Please describe the purpose of this pull request.

  • ChatUI serves static files to support web app
  • However, if users grab memgpt via pip install, there's no chatui directory (not bundled atm)
  • The current REST API code (run on memgpt server) assumes that the static dirs path already exists
    • So memgpt server is effectively broken in the current pip install

Have you tested this this PR?

Yes, this local diff on the pip install (0.3.1) fixes the problem:

% memgpt server
INFO:     Started server process [62156]
INFO:     Waiting for application startup.
Writing out openapi.json file
INFO:     Application startup complete.
INFO:     Uvicorn running on http://localhost:8283 (Press CTRL+C to quit)

@cpacker cpacker linked an issue Feb 12, 2024 that may be closed by this pull request
@cpacker
Copy link
Collaborator Author

cpacker commented Feb 12, 2024

@goetzrobin in your opinion is this the correct way to fix this issue (at least until chatui is bundled into the pip install too?)

@cpacker cpacker requested a review from sarahwooders February 12, 2024 01:41
@cpacker cpacker merged commit ab16809 into main Feb 12, 2024
5 checks passed
@cpacker cpacker deleted the fix-server branch February 12, 2024 02:47
norton120 pushed a commit to norton120/MemGPT that referenced this pull request Feb 15, 2024
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated to v 0.3.1: running server still a problem - missing dirs
1 participant