Cycle detection reports unrelated elements

[a-sr]

The cycle detection reports elements that are not included in the actual cycle.
In this example, a cycle is formed only by sim.theta -> con.theta -> con.control -> sim.control. Yet, all ports and reactions are reported as part of the cycle.

I already tested if the issue is caused by the visualization but ReactorInstance.getCycles() reports the following list as causality loop.

[
reaction_0 of main.sim, 
reaction_0 of main.con, 
reaction_0 of main.sou, 
reaction_0 of main.out, 
PortInstance main.con.theta, 
PortInstance main.sim.theta, 
PortInstance main.sou.angle, 
PortInstance main.out.theta, 
PortInstance main.sim.control, 
PortInstance main.con.control, 
PortInstance main.out.control, 
PortInstance main.out.led, 
PortInstance main.con.led, 
PortInstance main.out.speaker, 
PortInstance main.sou.sound
]

Hence, the problem seems to be in the cycle detection itself.

[edwardalee]

This is addressed by PR #1270.

[a-sr]

While PR #1270 solves most of the cases, the cycle detection still reports ports as part of a cycle if they are downstream of a reaction on the cycle, even if they do not contribute to the cycle.

In this example the game_over port is incorrectly reported.