Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use spotbugs for static code analysis and make the code base warning free #1806

Open
cmnrd opened this issue Jun 1, 2023 · 2 comments
Open
Labels
refactoring Code quality enhancement

Comments

@cmnrd
Copy link
Collaborator

cmnrd commented Jun 1, 2023

Now that we have formatting addressed, we should also introduce linting and enforce that the code is warning free. Gradle has a convenient plugin called checkstyle for linting java code. It supports various style guide rule sets, including Google's style guide. This should be a tremendous help in avoiding the most common errors such as the problems fixed in #1793. The biggest challenge, however, will be to fix all linter warnings in our existing code.

@cmnrd cmnrd added this to the 0.6.0 milestone Jun 1, 2023
@lhstrh
Copy link
Member

lhstrh commented Jun 2, 2023

Would be cool to set this up for reactor-c as well...

@cmnrd
Copy link
Collaborator Author

cmnrd commented Jun 2, 2023

For reactor-c you could just copy the clang-format and clang-tidy setup from reactor-cpp.

@cmnrd cmnrd closed this as completed Jun 2, 2023
@cmnrd cmnrd reopened this Jun 2, 2023
This was referenced Sep 13, 2023
@cmnrd cmnrd added the refactoring Code quality enhancement label Sep 14, 2023
@cmnrd cmnrd changed the title Use linter and enforce warning free code in CI Use spotbugs for static code analysis and make the code base warning free Sep 14, 2023
@lhstrh lhstrh modified the milestones: 0.6.0, 0.7.0 Nov 5, 2023
@lhstrh lhstrh modified the milestones: 0.7.0, 0.8.0 Mar 3, 2024
@cmnrd cmnrd removed this from the 0.8.0 milestone Jun 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactoring Code quality enhancement
Projects
None yet
Development

No branches or pull requests

2 participants