Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use the BenchmarkRunner reactor in all C benchmarks #764

Closed
cmnrd opened this issue Nov 22, 2021 · 0 comments · Fixed by #777
Closed

Use the BenchmarkRunner reactor in all C benchmarks #764

cmnrd opened this issue Nov 22, 2021 · 0 comments · Fixed by #777
Assignees
Labels
c Related to C target

Comments

@cmnrd
Copy link
Collaborator

cmnrd commented Nov 22, 2021

Some benchmarks are significantly influenced by caching effects. We observed this in particular in the Recursive Matrix Multiplication benchmark (see #749). By using the benchmark runner reactor, we can ensure that the benchmarks run with a warm cache. For consistency, and also to integrate the updated version of MatMul.lf with our runner script, we should update all C benchmarks to use the BenchmarkRunner reactor. Note that this BenchmarRunner should use the simplified pattern currently implemented in C++. The version currently used in MatMul.lf is unnecessarily complex.

@cmnrd cmnrd added the c Related to C target label Nov 22, 2021
@housengw housengw linked a pull request Jan 25, 2022 that will close this issue
22 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c Related to C target
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants