Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Examples need updating and curation #27

Closed
edwardalee opened this issue Mar 28, 2023 · 6 comments
Closed

Examples need updating and curation #27

edwardalee opened this issue Mar 28, 2023 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@edwardalee
Copy link
Contributor

I just did a random sample of some programs in C examples repo, and most examples I chose failed:

  • AnytimePrime.lf doesn't compile.
  • SensorSimulator.lf compiles and then segfaults.
  • Rhythm.lf segfaults.

Is it really too early in the development process to be actually developing applications?
Or are we not paying enough attention to backward compatibility?
Note that we can't expect outside users to commit a regression test for every application they develop.

@edwardalee
Copy link
Contributor Author

Fixed the segfaults in SensorSimulator.lf and Rhythm.lf. The distributed examples in Rhythm no longer work because of the restructured fed-gen folder structure. Looking for a fix now.

Also, all the examples need to be reformatted to get rid of warnings about now deprecated parameter overrides.

@edwardalee edwardalee self-assigned this Mar 28, 2023
@edwardalee
Copy link
Contributor Author

Fixed, reorganized, and documented the AnytimePrime.lf example.

@edwardalee edwardalee changed the title Random sample yields all failures Examples need updating and curation Mar 28, 2023
@lhstrh
Copy link
Member

lhstrh commented Mar 28, 2023

See #1.

@lhstrh
Copy link
Member

lhstrh commented Jun 7, 2023

A complete summary of broken examples can be found here: https://github.com/lf-lang/examples-lingua-franca/actions/runs/5194568881 (note that this does not include examples located in experimental or failing directories).

@lhstrh lhstrh mentioned this issue Jun 7, 2023
@lhstrh
Copy link
Member

lhstrh commented Jun 7, 2023

Remaining failures to be found here.

@lhstrh lhstrh added the help wanted Extra attention is needed label Jun 7, 2023
@cmnrd
Copy link
Contributor

cmnrd commented Jun 9, 2023

I created a new issue to better keep track of individual tasks #34. I close this issue in favor of the new one.

@cmnrd cmnrd closed this as completed Jun 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants