Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Examples failing #53

Closed
edwardalee opened this issue Jul 6, 2023 · 2 comments · Fixed by #58
Closed

Examples failing #53

edwardalee opened this issue Jul 6, 2023 · 2 comments · Fixed by #58
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@edwardalee
Copy link
Contributor

edwardalee commented Jul 6, 2023

A number of examples are failing due to issues that I do not know how to fix:

  • C/src/ProtocolBuffers/HelloProtocolBuffers.lf
    This one fails because protobufs is not installed in CI. How to install it? The instructions for installation are included in the .lf file.

  • C/src/DistributedHelloWorld/HelloWorldDecentralized.lf
    C/src/DistributedHelloWorld/HelloWorldDecentralizedSTP.lf
    These fail because of a bug in fedgen, reported in issue 1733 in lingua-franca: Inheritance not working with fedgen lingua-franca#1733. This bug needs to be fixed before a release.

There also seems to be a problem with memory management. With several examples, I get the following warning on exit:

WARNING: Memory allocated for messages has not been freed.
WARNING: Number of unfreed messages: 3.

For example, C/src/train-door/TrainDoorAsymetric.lf gives this.

@edwardalee edwardalee added bug Something isn't working help wanted Extra attention is needed labels Jul 6, 2023
@lhstrh
Copy link
Member

lhstrh commented Jul 6, 2023

A number of examples are failing due to issues that I do not know how to fix:

  • C/src/ProtocolBuffers/HelloProtocolBuffers.lf
    This one fails because protobufs is not installed in CI. How to install it? The instructions for installation are included in the .lf file.

I could add these dependencies in the CI workflows, but for these examples to work on the playground, the docker image used there will also need to have those dependencies installed. So what I'm thinking is that we should use the same docker image in CI and manage the dependencies there. Perhaps @axmmisaka could help us with since he's also the one who set up the playground.

@lhstrh
Copy link
Member

lhstrh commented Jul 7, 2023

* C/src/DistributedHelloWorld/HelloWorldDecentralized.lf

This is fixed in lf-lang/lingua-franca#1891.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants