From 8ded983f9e777d09e09fe66ebab466420c436ce1 Mon Sep 17 00:00:00 2001
From: Christian Menard <christian@xronos.com>
Date: Thu, 15 Aug 2024 13:21:11 +0200
Subject: [PATCH] update CI config

---
 .github/workflows/clang-format.yml | 10 +++-------
 .github/workflows/clang-tidy.yml   | 20 ++++++++++++++++++++
 .github/workflows/main.yaml        |  9 ++-------
 include/reactor-cpp/value_ptr.hh   |  2 +-
 4 files changed, 26 insertions(+), 15 deletions(-)
 create mode 100644 .github/workflows/clang-tidy.yml

diff --git a/.github/workflows/clang-format.yml b/.github/workflows/clang-format.yml
index bb38ef65..9d9efd5e 100644
--- a/.github/workflows/clang-format.yml
+++ b/.github/workflows/clang-format.yml
@@ -1,17 +1,13 @@
-name: clang-format-review
+name: check clang-format
 
 # You can be more specific, but it currently only works on pull requests
 on: [pull_request]
 
 jobs:
   clang-format:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v2
-      - name: Install clang-tidy
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y clang-tidy
+      - uses: actions/checkout@v4
       - name: Analyze
         run: |
           clang-format --dry-run --Werror -style=file $(find ./ -name '*.cc' -print)
diff --git a/.github/workflows/clang-tidy.yml b/.github/workflows/clang-tidy.yml
new file mode 100644
index 00000000..1b53076b
--- /dev/null
+++ b/.github/workflows/clang-tidy.yml
@@ -0,0 +1,20 @@
+name: check clang-tidy
+
+# You can be more specific, but it currently only works on pull requests
+on: [pull_request]
+
+jobs:
+  clang-tidy:
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+      - name: configure
+        run: |
+          mkdir build
+          cd build
+          cmake ..
+      - name: build the library
+        run: cmake --build build
+      - name: build examples
+        run:
+          cmake --build build --target examples
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
index d785eab1..4fe6c37c 100644
--- a/.github/workflows/main.yaml
+++ b/.github/workflows/main.yaml
@@ -17,17 +17,12 @@ jobs:
         os: [ubuntu-latest, windows-latest, macos-latest]
 
     steps:
-    - uses: actions/checkout@v1
-    - name: Install clang-tidy
-      run: |
-        sudo apt-get update
-        sudo apt-get install -y clang-tidy
-      if: matrix.os == 'ubuntu-latest'
+    - uses: actions/checkout@v4
     - name: configure
       run: |
         mkdir build
         cd build
-        cmake ..
+        cmake .. -DREACTOR_CPP_CLANG_TIDY=Off
     - name: build the library
       run: cmake --build build
     - name: build examples
diff --git a/include/reactor-cpp/value_ptr.hh b/include/reactor-cpp/value_ptr.hh
index 6a461cdc..a6d55089 100644
--- a/include/reactor-cpp/value_ptr.hh
+++ b/include/reactor-cpp/value_ptr.hh
@@ -355,7 +355,7 @@ public:
    * class:`ImmutableValuePtr`, the value is deleted.
    * @endrst
    */
-  auto operator=(ImmutableValuePtr&& ptr) -> ImmutableValuePtr& = default;
+  auto operator=(ImmutableValuePtr&& ptr) noexcept -> ImmutableValuePtr& = default;
 
   /**
    * Retrieve a raw pointer to the managed value.