Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support using certificates for Azure Key vault. #81

Open
sp98 opened this issue Jan 19, 2024 · 2 comments
Open

Support using certificates for Azure Key vault. #81

sp98 opened this issue Jan 19, 2024 · 2 comments

Comments

@sp98
Copy link

sp98 commented Jan 19, 2024

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST

What happened:
As of now, the azure key vault client can be created using the ClientID and ClientSecret. The recommended way of creating the client is using a certificate.

What you expected to happen:
Create azure key vault client using certificate. Use the NewServicePrincipalTokenFromCertificate function to generate the token using certificate.

How to reproduce it (as minimally and precisely as possible):
N/A

Anything else we need to know?:
N/A

Environment:

  • Container Orchestrator and version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@sp98
Copy link
Author

sp98 commented Jan 19, 2024

@adityadani

I'm from the Rook team.
I would like to take this up and work on it. Just wanted to check if you are still accepting contributions.

@adityadani
Copy link
Collaborator

@sp98 Yes feel free to send out a PR and we will review it. cc @dahuang-purestorage

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants