Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add /ipfs/0.1.0 to protocols page #323

Closed
DougAnderson444 opened this issue May 4, 2023 · 4 comments
Closed

add /ipfs/0.1.0 to protocols page #323

DougAnderson444 opened this issue May 4, 2023 · 4 comments

Comments

@DougAnderson444
Copy link

I see the subject protocol used in the code (like here libp2p/universal-connectivity#66), but didn't find an explanation in the docs (so far, perhaps I missed it).

Would be great if there was an addition to this page:

https://docs.libp2p.io/concepts/fundamentals/protocols/#core-libp2p-protocols

Also, is there a complete listing to all the protocol strings somewhere?

Does this just mean "use all protocols starting with /ipfs/**/** ?

@DougAnderson444
Copy link
Author

According to https://github.com/libp2p/rust-libp2p/blob/c93f753018af3a63c07e38c09672e0e1e8f1a385/protocols/identify/src/behaviour.rs#L79-L81 at least, it's described for Identify as

/// Application-specific version of the protocol family used by the peer,
/// e.g. `ipfs/1.0.0` or `polkadot/1.0.0`.

I know I would benefit from some detail about "protocol families" and how they relate to the protocol children.

Thanks!

@MarcoPolo
Copy link
Contributor

Not sure if this should go in the protocols page because this isn't a standalone protocol. This is an option in identify. The details are here: https://github.com/libp2p/specs/blob/master/identify/README.md#protocolversion

I agree this is a bit confusing.

@p-shahi
Copy link
Member

p-shahi commented May 15, 2023

ref: libp2p/go-libp2p#2294

@2color
Copy link
Contributor

2color commented Aug 13, 2024

Closing this issue, given that this is a protocol specific parameter. I also agree this is confusing, but this can likely just be resolved with a comment in the rust-libp2p implementation indicating that it's purely metadata.

@2color 2color closed this as completed Aug 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants