Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

content routing example with node1.peerStore.patch won't work anymore because of updates to the peerStore class structure in "libp2p": "0.40.0" #1737

Closed
TimDaub opened this issue May 4, 2023 · 6 comments
Labels
need/author-input Needs input from the original author

Comments

@TimDaub
Copy link
Contributor

TimDaub commented May 4, 2023

await node1.peerStore.patch(node2.peerId, {
multiaddrs: node2.getMultiaddrs()
})

I'm pretty sure this won't work because only the store implements these functions now: https://github.com/libp2p/js-libp2p-peer-store/blob/master/src/store.ts

@TimDaub TimDaub added the need/triage Needs initial labeling and prioritization label May 4, 2023
@achingbrain
Copy link
Member

This will be fixed by the 0.45.x release - #1707 - it pulls all these changes together.

@achingbrain
Copy link
Member

0.45.x has been shipped - please can you update all your @libp2p/* deps and try again?

@p-shahi
Copy link
Member

p-shahi commented Jun 6, 2023

@TimDaub Were you able to double check?

@achingbrain achingbrain added need/author-input Needs input from the original author need/triage Needs initial labeling and prioritization and removed need/author-input Needs input from the original author need/triage Needs initial labeling and prioritization labels Jun 11, 2023
@github-actions
Copy link
Contributor

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

@TimDaub
Copy link
Contributor Author

TimDaub commented Jun 18, 2023

nope sorry I won‘t check but thanks for solving

@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Jun 19, 2023
@achingbrain
Copy link
Member

Fair enough - please reopen if you encounter this again in future!

@github-project-automation github-project-automation bot moved this from 🥞Weekly Candidates/Discuss🎙 to 🎉Done in js-libp2p Jun 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
need/author-input Needs input from the original author
Projects
Archived in project
Development

No branches or pull requests

3 participants