rust-peer: Identify Protocol String

[DougAnderson444]

Is this supposed to be ipfs/id/1.0.0 (with /id/ in the middle) as per this page

universal-connectivity/rust-peer/src/main.rs

Lines 298 to 299 in 4a309e5

	let identify_config = identify::Behaviour::new(
	identify::Config::new("/ipfs/0.1.0".into(), local_key.public())

[DougAnderson444]

Did a bit more digging, perhaps it's more ipfs/0.1.0 needs to be added to that libp2p protocol page?

[mxinden]

For the sake of completeness, adding to the latest comment, the referenced /ipfs/0.1.0 is not the libp2p identify multistream-select protool name, but the general libp2p Protocol Version, see https://github.com/libp2p/specs/tree/master/identify#protocolversion.

[mxinden]

As far as I am aware, universal-connectivity nodes should not interact, nor act as normal IPFS nodes, thus they should like choose a different Protocol Version, e.g. /universal-connectiviy/0.1.0. That said, I am not aware of any code-path that actually acts upon the Protocol Version, thus this would be for humans only.

[DougAnderson444]

Thank @mxinden, I can appreciate your input here.

I am working on a plugin system idea for libp2p where this protocol name/version would come in handy to find other peers who run the same plugin protocol. Given there is no code path though, and usage seems to be a bit diverse across implementation, what would be the best approach? Could I build on what is already there effectively?

[2color]

So it seems that this is just setting the protocol_version which serves as just metadata and isn't acted on.

Moving forward, we can just change this to a custom string to avoid confusion with identify's multistream-select protocol name.