Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Interface for accessing labels in HTML::Form inputs [rt.cpan.org #47016] #14

Open
oalders opened this issue Mar 31, 2017 · 1 comment
Open

Comments

@oalders
Copy link
Member

oalders commented Mar 31, 2017

Migrated from rt.cpan.org#47016 (status was 'open')

Requestors:

Attachments:

From ykar@cpan.org on 2009-06-16 18:05:00:

I ask you to add interface for accessing input labels. It is currently
possible to get input's label through the $input->{value_name} in some
cases, but it not always corresponds to label. If label for input does
not exist, parser do some heuristic to guess "value_name" and swallow
all plain text following input through $p->get_phrase.

Furthermore current value_name parsing has a flaw: if label defined
after the input, the label is ignored (because at the time of parsing
of the input element there is no corresponding entry in %labels).

I'm proposing a patch which implements the interface for accessing
labels and label assignment is free from mentioned flaw (labels
assigned to inputs when form completely parsed).

Attached:
 - patch
 - test script

From ether@cpan.org on 2017-01-25 21:37:33:

migrated queue: libwww-perl -> WWW-Mechanize
@oalders oalders transferred this issue from libwww-perl/WWW-Mechanize Apr 4, 2019
@simbabque
Copy link
Contributor

The work that needs to be done here is to apply the original patch to a new branch, take the test file and integrate it into our tests, and then discuss whether this interface is useful, and possibly make changes.

@oalders oalders changed the title Interface for accesing labels in HTML::Form inputs [rt.cpan.org #47016] Interface for accessing labels in HTML::Form inputs [rt.cpan.org #47016] Oct 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants