LIP-6: burning the limited amount per single run [WIP] #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make front-running exploits on `processLidoOracleReport` unprofitable by burning the limited amount only per single report.
TheDZhon
changed the title
TheDZhon
changed the title
ujenjt
approved these changes
Jan 19, 2022
Comment on lines
85
to
86
| uint256 private maxBurnAmountPerRunBasePoints = 4; // 0.04% by default for the biggest `stETH:ETH` curve pool | ||
|
|
There was a problem hiding this comment.
Please consider to set the variable via constructor. It will save one extra call for setting via setter on deploy. 🙌
There was a problem hiding this comment.
I'll do it, an easy one 👍
Introduce new constructor param. Add tests.
arwer13
reviewed
Jan 23, 2022
The token standard has the following direct note: > Callers MUST handle false from returns (bool success). Callers MUST NOT assume that false is never returned!
Remove reduntant requiremenets. Remove a revert reason from tests.
RayLvv
pushed a commit
to okx-dao/lido-dao
that referenced
this pull request
Dec 12, 2022
LIP-6: burning the limited amount per single run [WIP]
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make front-running exploits on
processLidoOracleReportunprofitable by burning the limited amount only per single report.