Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Maybe emit transfer events inside of _transferShares() #422

Open
arwer13 opened this issue May 18, 2022 · 1 comment
Open

Maybe emit transfer events inside of _transferShares() #422

arwer13 opened this issue May 18, 2022 · 1 comment
Labels
discussion next-upgrade Things to pickup for the next protocol upgrade

Comments

@arwer13
Copy link
Contributor

arwer13 commented May 18, 2022

Based on this comment

The starting idea was just to move emitting Transfer and TransferShares events into _transferShares function to reduce code duplication.

But doing so also requires significant changes at least in distributeRewards function, which is a subject for further investigation.

Here is a sketch of the scope of the changes requried: #421
@arwer13 arwer13 mentioned this issue May 18, 2022
Merged
@TheDZhon TheDZhon added the next-upgrade Things to pickup for the next protocol upgrade label May 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
discussion next-upgrade Things to pickup for the next protocol upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheDZhon @arwer13 and others