Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Why do we need ILido.sol interface? #423

Closed
folkyatina opened this issue May 18, 2022 · 1 comment
Closed

Why do we need ILido.sol interface? #423

folkyatina opened this issue May 18, 2022 · 1 comment
Labels
next-upgrade Things to pickup for the next protocol upgrade

Comments

@folkyatina
Copy link
Member

It looks like:

  • it's inconsistent rn (contains some methods from StETH)
  • doubles the number of docs (makes it harder to support)
  • makes it more difficult to read Lido.sol (because you need to peek into ILido from time to time)

Should we get rid of it, like we did with IStETH.sol

@TheDZhon TheDZhon added the next-upgrade Things to pickup for the next protocol upgrade label May 19, 2022
@TheDZhon
Copy link
Contributor

Resolved in #482

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
next-upgrade Things to pickup for the next protocol upgrade
Projects
None yet
Development

No branches or pull requests

3 participants
@TheDZhon @folkyatina and others