Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

handleOracleReport doesn't emit events on state change #429

Closed
bulbozaur opened this issue May 20, 2022 · 3 comments · Fixed by #482
Closed

handleOracleReport doesn't emit events on state change #429

bulbozaur opened this issue May 20, 2022 · 3 comments · Fixed by #482
Labels
next-upgrade Things to pickup for the next protocol upgrade

Comments

@bulbozaur
Copy link
Contributor

handleOracleReport(uint256 _beaconValidators, uint256 _beaconBalance) sets BEACON_BALANCE_POSITION and BEACON_VALIDATORS_POSITION slot but don't emit events on this changes
in case of negative rebase it will update storage, but won't emit any events at all.

https://github.com/lidofinance/lido-dao/blob/08436ce13d67501fa723169c1dc69fe47b90cde4/contracts/0.4.24/Lido.sol#L487-L488
@TheDZhon TheDZhon added the next-upgrade Things to pickup for the next protocol upgrade label May 22, 2022
@bulbozaur bulbozaur changed the title handleOracleReport don't emit events on state change handleOracleReport doesn't emit events on state change Jun 27, 2022
@TheDZhon TheDZhon mentioned this issue Jan 31, 2023
Merged
@TheDZhon TheDZhon linked a pull request Jan 31, 2023 that will close this issue
Shapella upgrade (capella+shanghai) #482
Merged
@TheDZhon
Copy link
Contributor

Resolved in #482

@TheDZhon
Copy link
Contributor

TheDZhon commented Apr 6, 2023

Decided to re-open because V2 isn't deployed on mainnet yet.

@TheDZhon TheDZhon reopened this Apr 6, 2023
@TheDZhon
Copy link
Contributor

Resolved in https://github.com/lidofinance/lido-dao/releases/tag/v2.0.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
next-upgrade Things to pickup for the next protocol upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shapella upgrade (capella+shanghai) lidofinance/core
7 participants
@bulbozaur @TheDZhon and others