-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Slippage control upon withdrawals #694
Comments
Actually, I got it, in the context of the Lido withdrawals it doesn't make any sense. |
But wait, what if the following sequence of actions happens?
In case of the following sequence of txs, nothing weird happens. But what if the Bob's withdrawal request comes right after AccountingOracle's report(which will report negative rebase) in the same block? In this case, the bunker mode is not activated yet, but it seems Bob loses some funds due to the negative rebase. |
Anyways, I think it's better to have some slippage control mechanism for unexpected cases like that. |
Hey, @Rassska The current architecture presumes strict FIFO ordering of finalization, and requests aren't cancellable. To overcome the issue, one might want to exchange stETH for ETH on secondary markets or sell the already placed request position represented as an ERC721-compatible token (NFT). |
Of course, the probability for such case is pretty low, but as I got it correctly it makes some sense:
As a result, after 36 days or when bunker mode is de-ativated and the batch which contains Bob's withdrawal is finalized, Bob receives less amount of ETH compared to the case where he simply could front-run tx2 which causes the negative rebase. I mean, the whole concept here is to explore some withdrawal requests passed right after negative rebase happens. Anyways, thanks a lot, I'm just exploring the Lido for fun! |
I see your point, yet the bunker mode activates retroactively, practically excluding the probability of the bunker mode front-running (by means of the associated frame definition of the withdrawal request) see the second rule for the 'Withdrawal requests finalization' section Nevertheless, maybe you see any additional weaknesses? 👀 |
Thanks a lot, gotcha! |
Hey there, hope you're doing fine!
Do I get it right, that the current version of the feature/shapella-upgrade doesn't provide any opportunity for users to set the desired slippage on-chain upon withdrawals?
Thanks!
The text was updated successfully, but these errors were encountered: