Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: named slots context autocomplete #381

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Apr 21, 2022

implemented named slots context autocomplete

my-component

{{yield (hash Foo=(component "Bar")) to="body"}}

component-usage

<MyComponent>
  <:body as |k|>
   <k - {k.Foo autocomplete} >
  </body>
</MyComponent>

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #381 (5d738dd) into component-context-info-origin (5f3e91d) will decrease coverage by 0.15%.
The diff coverage is 64.70%.

❗ Current head 5d738dd differs from pull request most recent head 1fae3cd. Consider uploading reports for the commit 1fae3cd to get more accurate results

@@                        Coverage Diff                        @@
##           component-context-info-origin     #381      +/-   ##
=================================================================
- Coverage                          72.40%   72.25%   -0.16%     
=================================================================
  Files                                 57       57              
  Lines                               4871     4883      +12     
  Branches                             946      950       +4     
=================================================================
+ Hits                                3527     3528       +1     
- Misses                              1344     1355      +11     
Impacted Files Coverage Δ
src/utils/usages-api.ts 56.57% <50.00%> (ø)
src/glimmer-utils.ts 50.50% <61.53%> (+0.50%) ⬆️
...uiltin-addons/core/template-completion-provider.ts 93.02% <100.00%> (ø)
src/utils/yield-context-extractor.ts 54.40% <0.00%> (-4.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3e91d...1fae3cd. Read the comment docs.

feat: improve yield context resolution performance

feat: improve yield context resolution performance

improve named slots context autocomplete

failing test

update samples

fix slot name
@lifeart lifeart force-pushed the yield-context-performance branch from ce28cd6 to 1fae3cd Compare April 21, 2022 09:56
@lifeart lifeart merged commit ab8b888 into component-context-info-origin Apr 21, 2022
@lifeart lifeart deleted the yield-context-performance branch April 21, 2022 10:45
lifeart pushed a commit that referenced this pull request Apr 21, 2022
# [2.23.0](v2.22.0...v2.23.0) (2022-04-21)

### Features

* named slots context autocomplete ([#381](#381)) ([ab8b888](ab8b888))
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant