Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid killing mill daemon if Ctrl-C interrupt occurs during file-watching mode #327

Closed
lihaoyi opened this issue May 16, 2018 · 0 comments · Fixed by #339
Closed

Avoid killing mill daemon if Ctrl-C interrupt occurs during file-watching mode #327

lihaoyi opened this issue May 16, 2018 · 0 comments · Fixed by #339

Comments

@lihaoyi
Copy link
Member

lihaoyi commented May 16, 2018

Currently, we kill the Mill daemon every time you Ctrl-C on the Mill client, as we do not want a useless background daemon running forever unnecessarily and we also cannot trust the JVM not to fall into a bad state using Thread.stop to interrupt the computation (in Ammonite the JVM does fall into a bad state sometimes, but since it's an interactive repl it's much easier to notice/remedy than if the Mill background daemon did the same).

However, once Mill has completed running it's task and is in --watch/-w mode, Ctrl-C should allow the Mill client to exit without killing the Mill server, since the watch loop should be trivially stop-able. That would avoid paying the cost of spinning up a new JVM every time you exit --watch

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant