Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace timeouts with ctx #39

Open
jtagcat opened this issue Nov 7, 2023 · 2 comments · May be fixed by #54
Open

Replace timeouts with ctx #39

jtagcat opened this issue Nov 7, 2023 · 2 comments · May be fixed by #54

Comments

@jtagcat
Copy link

jtagcat commented Nov 7, 2023 •
edited
Loading

https://pkg.go.dev/context

Functions should use ctx as argument. Context should be passed around (using DialContext instead of Dial), or checked with ctx.Done.
@likexian
Copy link
Owner

Hello @jtagcat
Thanks for your feedback, I will do it.

If you think this repository is helpful, please share it with friends, thanks.

@gnuletik
Copy link

Thanks for your feedback @likexian (and for this great lib)!
Having context support is important for us.
Is there anything we can do to help this be implemented?

@babariviere babariviere linked a pull request Dec 30, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add WhoisContext and use context for all queries babariviere/whois
3 participants
@likexian @gnuletik @jtagcat