Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

clonefile() needs to fall back to regular copy for cross-device copying #1557

Closed
jandubois opened this issue May 19, 2023 · 1 comment · Fixed by #1558
Closed

clonefile() needs to fall back to regular copy for cross-device copying #1557

jandubois opened this issue May 19, 2023 · 1 comment · Fixed by #1558
Labels
bug Something isn't working priority/high
Milestone
v0.16.0

Comments

@jandubois
Copy link
Member

#1411 brought in support for copying files on macOS using clonefile, but there is no fallback for cross-device copies:

INFO[0000] Terminal is not available, proceeding without opening an editor
INFO[0000] Attempting to download the image              arch=x86_64 digest= location=/Users/jan/suse/alpine-lima/iso/alpine-lima-std-3.18.0-x86_64.iso
FATA[0000] failed to download "/Users/jan/suse/alpine-lima/iso/alpine-lima-std-3.18.0-x86_64.iso": clonefile failed: cross-device link
@jandubois jandubois added the bug Something isn't working label May 19, 2023
@jandubois jandubois added this to the v0.16.0 milestone May 19, 2023
@jandubois
Copy link
Member Author

Upstream fix in containerd/continuity#225

@AkihiroSuda AkihiroSuda linked a pull request May 20, 2023 that will close this issue
build(deps): bump github.com/containerd/continuity from 0.4.0 to 0.4.1 #1558
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working priority/high
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

build(deps): bump github.com/containerd/continuity from 0.4.0 to 0.4.1 lima-vm/lima
1 participant
@jandubois