Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Decouple pkg/start (and others) from VM driver internals #1746

Open
AkihiroSuda opened this issue Aug 14, 2023 · 4 comments · May be fixed by #3377
Open

Decouple pkg/start (and others) from VM driver internals #1746

AkihiroSuda opened this issue Aug 14, 2023 · 4 comments · May be fixed by #3377
Labels
kind/refactoring Refactoring

Comments

@AkihiroSuda
Copy link
Member

lima/pkg/start/start.go

Line 18 in bee0502

"github.com/lima-vm/lima/pkg/qemu"

The package should be decoupled from qemu driver internals
@AkihiroSuda AkihiroSuda added the kind/refactoring Refactoring label Aug 14, 2023
@kairveeehh
Copy link
Contributor

hii , is this issue stale as the current codebase does not have the required file?

@AkihiroSuda
Copy link
Member Author

No, this still has to be fixed

lima/pkg/instance/start.go

Line 25 in 7d5b7bd

"github.com/lima-vm/lima/pkg/qemu"

@kairveeehh
Copy link
Contributor

on it 🖖🏻

@kairveeehh
Copy link
Contributor

so over here in
start.go:110 and
start.go:114

should I use the driverInterface or like modify it for new functions?

@unsuman unsuman linked a pull request Mar 24, 2025 that will close this issue
Draft
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
kind/refactoring Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: Decouple Qemu Internal from pkg/instance unsuman/lima
2 participants
@AkihiroSuda @kairveeehh