From bba7af5980589755975f36a1e093ec427f11fcc5 Mon Sep 17 00:00:00 2001
From: Yuta Kasai <kasai.yuta0810@gmail.com>
Date: Thu, 23 Jan 2025 11:44:34 +0900
Subject: [PATCH] Fix double-quote handling in release creation workflow
 (#1139)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This PR escapes the release title’s double quotes and provides the
release notes via a file, preventing shell interpretation errors in the
gh release create command.

Current workflow fails when
(1) release title contains `"`:
https://github.com/line/line-bot-sdk-java/actions/runs/12886931493/job/35928566569#step:6:3
or (2) PR title contains `"` (e.g. on reverting change, title is `revert
"original title"`)

(same as https://github.com/line/line-bot-sdk-java/pull/1536)
---
 .github/workflows/create-draft-release.yml | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/create-draft-release.yml b/.github/workflows/create-draft-release.yml
index 6e267f7f..95c4b465 100644
--- a/.github/workflows/create-draft-release.yml
+++ b/.github/workflows/create-draft-release.yml
@@ -106,11 +106,25 @@ jobs:
             console.log(`releaseNotes (modified): ${JSON.stringify(modifiedBody, null, 2)}`);
             core.setOutput("release_body", modifiedBody);
 
+      - name: Prepare Release Title
+        id: title
+        env:
+          # "vX.Y.Z Release Title"
+          RAW_TITLE: ${{ steps.calculate-version.outputs.new_version }} ${{ github.event.inputs.release_title }}
+        run: |
+          # Print RAW_TITLE safely, then escape double quotes
+          SANITIZED_TITLE="$(printf '%s' "$RAW_TITLE" | sed 's/"/\\"/g')"
+          echo "sanitized_title=$SANITIZED_TITLE" >> "$GITHUB_OUTPUT"
+
+      - name: Write Release Notes to File
+        run: |
+          echo "${{ steps.generate-release-notes.outputs.release_body }}" > release-notes.txt
+
       - name: Create Draft Release
         run: |
           gh release create "${{ steps.calculate-version.outputs.new_version }}" \
-            --title "${{ steps.calculate-version.outputs.new_version }} ${{ github.event.inputs.release_title }}" \
-            --notes "${{ steps.generate-release-notes.outputs.release_body }}" \
+            --title "${{ steps.title.outputs.sanitized_title }}" \
+            --notes-file release-notes.txt \
             --draft \
             --repo "${{ github.repository }}"
         env: