Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

migrate from jest to node test runner #4

Merged
merged 6 commits into from
Sep 22, 2023
Merged

migrate from jest to node test runner #4

merged 6 commits into from
Sep 22, 2023
+2,230 −6,725

Conversation

kazushisan
Copy link
Contributor

@kazushisan kazushisan commented Sep 22, 2023 •
edited
Loading

Node.js v20 will become active LTS from 2023-10-24.

since the test runner is stable as of v20, I think we're ready to change the test runner from jest to node:test

some benefits of this migration are...

  • remove dependency and remove the need to manage complex config for jest
  • runs tests in a setup that's similar to the actual execution environment

@kazushisan kazushisan self-assigned this Sep 22, 2023
Base automatically changed from chore/add-github-actions to main September 22, 2023 04:07
@kazushisan kazushisan requested a review from potato4d September 22, 2023 04:07
@kazushisan kazushisan marked this pull request as ready for review September 22, 2023 04:07
potato4d
potato4d approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazushisan kazushisan merged commit 23ef990 into main Sep 22, 2023
@kazushisan kazushisan deleted the test/migrate-to-node-test-runner branch September 22, 2023 06:23
@kazushisan kazushisan mentioned this pull request Sep 22, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@potato4d potato4d potato4d approved these changes

@AsukaCHikaru AsukaCHikaru Awaiting requested review from AsukaCHikaru

@isoken26 isoken26 Awaiting requested review from isoken26

@G4RDS G4RDS Awaiting requested review from G4RDS

@itatchi3 itatchi3 Awaiting requested review from itatchi3

Assignees

@kazushisan kazushisan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazushisan @potato4d