Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds option for shallow cloning #469

Closed

Conversation

svalo
Copy link

@svalo svalo commented Aug 6, 2023

Accepts an aribitrary number of commits to allow flexibility

Fixes: #282

Accepts an aribitrary number of commits to allow flexibility

Fixes: 282
@svalo
Copy link
Author

svalo commented Aug 30, 2023

Hi @petefoth are there any updates on this? If there is anything that needs to be changed I can take care of it

@petefoth
Copy link
Contributor

Hi @petefoth are there any updates on this? If there is anything that needs to be changed I can take care of it

There is another PR (#431) which achieves the same but in a more general way. I was thinking merging that PR rather than this one, because it is more flexible and future-proof. I'd be interested in your comments on that PR before I make a decision

@petefoth petefoth mentioned this pull request Aug 30, 2023
@petefoth
Copy link
Contributor

I'll make a decision this evening on which PR to merge, so the merge can happen before the September build run starts

@petefoth
Copy link
Contributor

I decided to merge #431 instead, as it has more flexibility

Thanks for your contribution though.

@petefoth petefoth closed this Aug 30, 2023
@svalo
Copy link
Author

svalo commented Aug 31, 2023

There is another PR (#431) which achieves the same but in a more general way. I was thinking merging that PR rather than this one, because it is more flexible and future-proof. I'd be interested in your comments on that PR before I make a decision

Yup, fine for me, I opened this one as I had the perception that the other was too broad and you were more favorable about the specific functionality.

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support shallow clones
2 participants