Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Glif parsing: ensure outline element has no attributes #250

Open
madig opened this issue Jan 14, 2022 · 0 comments
Open

Glif parsing: ensure outline element has no attributes #250

madig opened this issue Jan 14, 2022 · 0 comments

Comments

@madig
Copy link
Collaborator

madig commented Jan 14, 2022

Minor issue, but we don't do it currently.

norad/src/glyph/parse.rs

Lines 127 to 136 in 2789dbe

fn parse_outline(
&mut self,
reader: &mut Reader<&[u8]>,
buf: &mut Vec<u8>,
) -> Result<(), GlifLoadError> {
let mut outline_builder = OutlineBuilder::new();
// TODO: Not checking for (the absence of) attributes here because we'd need to
// pass through the element data, but that'd clash with the mutable borrow of
// buf. Better way?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant