Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Privates #9

Open
eriq-augustine opened this issue Apr 9, 2019 · 1 comment
Open

Privates #9

eriq-augustine opened this issue Apr 9, 2019 · 1 comment
Labels
Admin - Good First Difficulty - Easy Priority - Normal Type - Refactor

Comments

@eriq-augustine
Copy link
Member

Enforce the _private convention.
@eriq-augustine
Copy link
Member Author

We should also add a CI check that looks for violations.
I don't know if flake8 has any plugins for this, but it would also be easy to implement something that looks for this.
Like:

grep -RP '(?<!self|super\(\))\._' pacai

@eriq-augustine eriq-augustine mentioned this issue Sep 13, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Admin - Good First Difficulty - Easy Priority - Normal Type - Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eriq-augustine