Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cinnamon-maximus@fmete Could not find XID for window with title #428

Open
nipperv opened this issue Oct 28, 2022 · 4 comments
Open

cinnamon-maximus@fmete Could not find XID for window with title #428

nipperv opened this issue Oct 28, 2022 · 4 comments

Comments

@nipperv
Copy link

nipperv commented Oct 28, 2022

cinnamon-maximus@fmete
 * Extension version/Build date (to be found in "About.." or in "metadata.json") 0.4.7
 * Cinnamon version (cinnamon --version) 5.4.12
 * Distribution - (Mint 17.2, Arch, Fedora 25, etc...) Mint 21
 * Graphics hardware *and* driver used intell
 * Snippet or attachment of ~/.cinnamon/glass.log
 * Snippet or attachment of ~/.xsession-errors
Gjs-Message: 21:28:09.558: JS LOG: [LookingGlass/info] [maximus] onMaximize: New Issue · linuxmint/cinnamon-spices-extensions - Vivaldi [Vivaldi-stable]
Gjs-Message: 21:28:09.559: JS LOG: [LookingGlass/info] [maximus] Could not find XID for window with title '${win.title}
Gjs-Message: 21:28:09.560: JS LOG: [LookingGlass/info] [maximus] xprop -name New Issue · linuxmint/cinnamon-spices-extensions - Vivaldi -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS 0x2, 0x0, 0x2, 0x0, 0x0
Gjs-Message: 21:28:10.149: JS LOG: [LookingGlass/info] [maximus] onUnmaximize: New Issue · linuxmint/cinnamon-spices-extensions - Vivaldi [Vivaldi-stable]
Gjs-Message: 21:28:10.150: JS LOG: [LookingGlass/info] [maximus] Could not find XID for window with title '${win.title}
Gjs-Message: 21:28:10.151: JS LOG: [LookingGlass/info] [maximus] xprop -name New Issue · linuxmint/cinnamon-spices-extensions - Vivaldi -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS 0x2, 0x0, 0x1, 0x0, 0x0

Notify author of extension
@

Issue

cinnamon-maximus does not remove window decoration

Steps to reproduce
Press Alt-F10

Expected behaviour

Other information

@JaxxArmstrong
Copy link

I have the same issue on Linux Mint 21.1.


Gjs-Message: 12:04:34.915: JS LOG: [LookingGlass/info] [maximus] Could not find XID for window with title '${win.title}
Gjs-Message: 12:04:34.915: JS LOG: [LookingGlass/info] [maximus] xprop -name Terminal -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS 0x2, 0x0, 0x2, 0x0, 0x0
Gjs-Message: 12:04:34.919: JS LOG: [LookingGlass/info] [maximus] onWindowAdded:
Terminal/Gnome-terminal
initially decorated? undefined
Gjs-Message: 12:04:34.919: JS LOG: [LookingGlass/info] [maximus] Could not find XID for window with title '${win.title}
Gjs-Message: 12:04:34.919: JS LOG: [LookingGlass/info] [maximus] xprop -name Terminal -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS 0x2, 0x0, 0x2, 0x0, 0x0


@hylkevds
Copy link

I just ran into the same issue for Evolution. Could it be because Evolution changes the window title to indicate the number of unread messages? The actual window title is: Inbox (1 unread) — Evolution. Also note the UTF-8 large dash.

@femike
Copy link

femike commented Mar 12, 2023

I solved my problem changed method to get window id with win.get_description() insteadof win.get_xwindow() in a new Meta.Window have no method get_xwindow()
But problem with title still opened.

:file=extension.js

function guessWindowXID(win) {
    let id = null;
    try {
        id = win.get_xwindow();
        if (id)
            return id;
    } catch (err) {
    }
    // debugging for when people find bugs.. always logging this message.
    logMessage("Could not find XID for window with title '${win.title}", true);
    return null;
}
function guessWindowXID(win) {
    let id = null;
    try {
        id = win.get_description();
        if (id)
            return id;
    } catch (err) {
    }
    // debugging for when people find bugs.. always logging this message.
    logMessage("Could not find XID for window with title '${win.title}", true);
    return null;
}

@nborisenkov
Copy link

@femike Thanks, this helped me with some windows (konsole, sublime text) on Ubuntu 23.04. Now this extension works with all windows.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants