Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changes in coriolis that require changes in alliance-test-suite are difficult #35

Open
robtaylor opened this issue Sep 2, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@robtaylor
Copy link
Collaborator

At the moment, if one needs to change alliance-check-toolkit for a change in coriolis, there's not a good sequence to do it in - you'll either have the new PR failing regression check, or main failing.

Any thoughts welcome!

@robtaylor robtaylor added the help wanted Extra attention is needed label Sep 2, 2023
@Coloquinte
Copy link
Collaborator

Coloquinte commented Oct 18, 2023

I grappled with the same issue. It would be nice to be able to run old commits with newer versions of alliance-check-toolkit as well. My solution would be to add a "ref" to the checkout of alliance-check-toolkit in .github/workflows/regressions.yml. This way we point a specific commit or tag that should work.

- uses: actions/checkout@v3
       with:
         repository: lip6/alliance-check-toolkit
         path:       coriolis-2.x/src/alliance-check-toolkit
         ref:        67b799e7b208

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants