Skip to content

Commit

Permalink
Merge pull request #175 from TomaszWaszczyk/master
Browse files Browse the repository at this point in the history
evaluation(subgame): comments regarding the whitepaper
  • Loading branch information
Noc2 authored May 17, 2021
2 parents 80f9b7a + 72cb2c7 commit 52a5489
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions evaluations/subgame_milestone-1_tomaszwaszczyk.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
| Number | Deliverable | Accepted | Link | Evaluation Notes |
| ------ | ----------- | -------- | ---- |----------------- |
| 1. | License | <ul><li>[X] </li></ul> | [https://github.com/SubGame-Network/subgame-network/blob/master/LICENSE](https://github.com/SubGame-Network/subgame-network/blob/master/LICENSE) | Looks good to me |
| 2. | Documentation | <ul><li>[] </li></ul> | [https://subgame.guanfantech.com/api/assets/whitePaper/en/%E6%8A%80%E8%A1%93%E7%99%BD%E7%9A%AE%E6%9B%B8_%E8%8B%B1%E6%96%87_v7.pdf](https://subgame.guanfantech.com/api/assets/whitePaper/en/%E6%8A%80%E8%A1%93%E7%99%BD%E7%9A%AE%E6%9B%B8_%E8%8B%B1%E6%96%87_v7.pdf) | Name of the file shall be English-like, look at General Notes section. Correct me if I am wrong but [here](https://github.com/w3f/Grant-Milestone-Delivery/pull/160/files#diff-3429cc6f7805248f1a79ebd7d5844662182caab60c2f7fed3d0775ffd23aeb81R19) is still Taiwanese name of the file |
| 2. | Documentation | <ul><li>[X] </li></ul> | [https://subgame.org/api/assets/whitePaper/en/White%20Paper_v9.pdf](https://subgame.org/api/assets/whitePaper/en/White%20Paper_v9.pdf) | Looks good to me, I think that you need to update the link to version 9 [here](https://github.com/w3f/Grant-Milestone-Delivery/pull/160/files#diff-3429cc6f7805248f1a79ebd7d5844662182caab60c2f7fed3d0775ffd23aeb81R19) |
| 3. | Testing Guide | <ul><li>[] </li></ul> | [https://github.com/SubGame-Network/subgame-network/tree/master/pallets](https://github.com/SubGame-Network/subgame-network/tree/master/pallets) | Taiwanese [comments](https://github.com/SubGame-Network/subgame-network/blob/master/pallets/chips/src/mock.rs#L86) |
| 4. | SubGame Node | <ul><li>[X]</li></ul> | [https://github.com/SubGame-Network/subgame-network/tree/master/node](https://github.com/SubGame-Network/subgame-network/tree/master/node) | Readable source code, cool [optimization](https://github.com/SubGame-Network/subgame-network/blob/master/node/src/service.rs#L238) |
| 5. | pallet-chips | <ul><li>[] </li></ul> | [https://github.com/SubGame-Network/subgame-network/tree/master/pallets/chips](https://github.com/SubGame-Network/subgame-network/tree/master/pallets/chips) | Much better, I am able to read the code, but look at here [Taiwanese comments](https://github.com/SubGame-Network/subgame-network/blob/master/pallets/chips/src/tests.rs) |
Expand All @@ -23,4 +23,4 @@

## General Notes

The progress was made, when I was trying to open a new version of the whitepaper I saw the error, I am not able to open the whitepaper at all. Still lack of Rustdoc. Some comments I have included in comments section above, really curios why have you exposed public all functions but not `DrawMap`, [link](https://github.com/SubGame-Network/subgame-network/blob/master/pallets/gamecenter/src/lib.rs#L52).
Removing suggestion in the whitepaper that implementation of bridge will include artificial intelligence do the job, I am pretty sure that implementation of any bridge in the Polkadot does not need artificial intelligence. Still lack of Rustdoc although do not think that it is crucial but nice to have. Some comments I have included in comments section above, really curios why have you exposed public all functions but not `DrawMap`, [link](https://github.com/SubGame-Network/subgame-network/blob/master/pallets/gamecenter/src/lib.rs#L52).

0 comments on commit 52a5489

Please # to comment.