Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bad return from provider #234

Closed
meck opened this issue Jan 13, 2020 · 5 comments · Fixed by #237
Closed

Bad return from provider #234

meck opened this issue Jan 13, 2020 · 5 comments · Fixed by #237
Labels
bug Something isn't working job neovim

Comments

@meck
Copy link
Contributor

meck commented Jan 13, 2020

Environment (please complete the following information):

  • OS: macOs
  • (Neo)Vim version: 0.4.3
  • vim-clap version: Head
  • Have you reproduced with a minimal vimrc: yes

Im having trouble with a provider I wrote, its calling out to hoogle and returning haskell function definitions. when use clap#dispatcher#job_start() the results are missing a lot of entries and not returning the top ones. But if I use maple with the same command all is well.

Minimal version of the provider It feels like something is not escaped maybe vim script is not a strongpoint for me.

Correct output (maple):

Skärmavbild 2020-01-13 kl 15 21 26

### Bad Output:

Skärmavbild 2020-01-13 kl 15 20 49
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.64. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Jan 13, 2020
@liuchengxu
Copy link
Owner

Does this issue happen just recently? If so, can you see which commit could be the culprit?

@meck
Copy link
Contributor Author

meck commented Jan 13, 2020

I did a bisect and it seems the issue was introduced in b1fda94

liuchengxu added a commit that referenced this issue Jan 14, 2020
@liuchengxu
Use s:loaded_size instead of line_count of neovim as we don't clear the
d7939ea 
old content

Close #234
@liuchengxu liuchengxu mentioned this issue Jan 14, 2020
Merged
@liuchengxu
Copy link
Owner

See if #237 fixes this issue.

@meck
Copy link
Contributor Author

meck commented Jan 14, 2020

Yes, looks good!

liuchengxu added a commit that referenced this issue Jan 14, 2020
@liuchengxu
Use s:loaded_size instead of line_count of neovim as we don't clear t…
1fce388 
…he old content (#237)

* Use s:loaded_size instead of line_count of neovim as we don't clear the
old content

Close #234

* Don't have to use line_count()

* Refactoring a bit

* .

* Update CHANGELOG.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working job neovim
Projects
None yet
Milestone
No milestone
2 participants
@meck @liuchengxu